Wireshark-commits: [Wireshark-commits] master 3707fd0: Use proto_tree_add_item_ret_display_string()
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 19 Jul 2019 20:59:26 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3707fd0ed036380ea4b540aa31060b2e2d9d9aff
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3707fd0 by Guy Harris (guy@xxxxxxxxxxxx):

    Use proto_tree_add_item_ret_display_string() to add string items.
    
    It does all the work done by the calls it replaces, *and* it takes an
    encoding argument, so the string data is converted, if necessary, to
    UTF-8.  (Not necessary in this case, at least as I read the protocol
    spec, but it's the right thing to do in any case.)
    
    Plus, as we're using proto_tree_add_item_ret_display_string(), the
    string we're displaying will be in a displayable format.
    
    Change-Id: I7f5e46dcdbb8f3d3749ef539a31f6208371b72cd
    Reviewed-on: https://code.wireshark.org/review/34022
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  3c7ec12   Provide only one data rate per user for VHT frames.
     add  3707fd0   Use proto_tree_add_item_ret_display_string() to add string items.


Summary of changes:
 epan/dissectors/packet-protobuf.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)