Wireshark-commits: [Wireshark-commits] master 2c7a35b: Qt: Fix various issues for profile manager
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 18 Jul 2019 05:45:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2c7a35bc987f0996180ba49e646a5e2ef613a003
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

2c7a35b by Roland Knall (rknall@xxxxxxxxx):

    Qt: Fix various issues for profile manager
    
    - Fixing the fact, that the profile did not allways switch to the active profile
    when pressing the OK button.
    - Adding a new profile can be repeated, if the name "New Profile" is already in
    use, a number is incremented and added to subsequently new profiles.
    - Copying a profile multiple times, creates individual names each time
    - Global profiles should come last in the statusbar popup
    - Global profiles should be called "System profiles"
    - Fix null-pointer that could happen while querying "DATA_IS_SELECTED"
    - Renaming an existing profile was not correctly indicated
    - Renaming the currently selected profile works now
    
    Change-Id: Ifa47fd672a6976c07d3e80741cfd61b548a5e1f8
    Reviewed-on: https://code.wireshark.org/review/33921
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  85e32bd   ZigBee: Add Address fields
     add  2c7a35b   Qt: Fix various issues for profile manager


Summary of changes:
 ui/qt/main_status_bar.cpp           | 12 ++++++---
 ui/qt/models/profile_model.cpp      | 51 ++++++++++++++++++++++++++-----------
 ui/qt/models/profile_model.h        |  5 +++-
 ui/qt/profile_dialog.cpp            | 51 +++++++++++++++++++++++--------------
 ui/qt/profile_dialog.ui             | 48 ++++++++++++++++++++++++++++++----
 ui/qt/widgets/profile_tree_view.cpp | 10 ++++++++
 6 files changed, 133 insertions(+), 44 deletions(-)