Wireshark-commits: [Wireshark-commits] master 4450cf7: Clean up string handling.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 17 Jul 2019 07:22:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4450cf73a42bd939b98fd3cff1c6a2be8f35c97c
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4450cf7 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up string handling.
    
    Use tvb_get_string_enc() routines to fetch strings; all strings must
    have an encoding value, to properly map to UTF-8.
    
    Use format_text() when displaying string values in columns.
    
    Show the interpretation of "character set" values.
    
    Choose the encoding value based on the "character set" value.
    
    While we're at it, use the XDLC_S_U_MASK #define, rather than a raw hex
    value, when testing for S frames vs. U frames.
    
    Change-Id: Idf9d6302473bbffdfa67341c381575aa525a6d84
    Reviewed-on: https://code.wireshark.org/review/33982
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  fb0cb63   BGP: Update description for IE Flag (EVPN IGMP)
     add  4450cf7   Clean up string handling.


Summary of changes:
 plugins/epan/irda/packet-irda.c | 158 +++++++++++++++++++++++++++++-----------
 1 file changed, 116 insertions(+), 42 deletions(-)