Wireshark-commits: [Wireshark-commits] master c914da2: Don't just grab raw string data with tvb_mem
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 17 Jul 2019 04:33:49 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c914da23f8cbb67299c161a95be32298a714786e
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c914da2 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't just grab raw string data with tvb_memcpy().
    
    Use tvb_get_string_enc() to fetch strings.  That way, all strings are
    fetched using an encoding value, to properly map to UTF-8.
    
    While we're at it, add the RFC for the final version of the protocol.
    
    Change-Id: If103d9464a313bd61948b931291a3763ea85d01b
    Reviewed-on: https://code.wireshark.org/review/33981
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  81e2d2a   Don't just grab raw string data with tvb_memcpy().
     add  c914da2   Don't just grab raw string data with tvb_memcpy().


Summary of changes:
 epan/dissectors/packet-zrtp.c | 40 +++++++++++++++-------------------------
 1 file changed, 15 insertions(+), 25 deletions(-)