Wireshark · Wireshark-commits: [Wireshark-commits] master 6a7b012: Don't just grab raw string data with tvb_memcpy().

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6a7b01255a95740900a402e1ac9d66ab771310da
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6a7b012 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't just grab raw string data with tvb_memcpy().
    
    Use proto_tree_add_item...() routines to add strings; use
    tvb_get_string_enc() to extract strings.  That way, all strings are
    fetched using an encoding value, to properly map to UTF-8.
    
    Change-Id: I2118e812965cfad5d8c288ea40fa50aca9c67fa8
    Reviewed-on: https://code.wireshark.org/review/33970
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1e630b4   gvcp, gvsp, u3v: GEV 2.2, new PFNC pixel formats
     add  6a7b012   Don't just grab raw string data with tvb_memcpy().


Summary of changes:
 epan/dissectors/packet-arp.c        | 14 +-------------
 epan/dissectors/packet-hsrp.c       | 22 ++++++++++------------
 epan/dissectors/packet-igap.c       | 20 +++++++++++---------
 epan/dissectors/packet-ipdc.c       |  5 ++---
 epan/dissectors/packet-ipmi-trace.c |  7 ++-----
 epan/dissectors/packet-zbee-zdp.c   |  6 +++---
 6 files changed, 29 insertions(+), 45 deletions(-)