Wireshark-commits: [Wireshark-commits] master 1a91aac: Use proto_tree_add_item_ret_string() to add
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 15 Jul 2019 18:42:18 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1a91aac9747ec3d937dd20ec962c86a149248876
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1a91aac by Guy Harris (guy@xxxxxxxxxxxx):

    Use proto_tree_add_item_ret_string() to add strings.
    
    Don't just grab raw string data with tvb_memcpy(); all strings must be
    fetched using an encoding value, to properly map to UTF-8.
    
    Use the newly-added ENC_ISO_646_BASIC encoding, as that's what the 2003
    DICOM spec says is used.
    
    Change-Id: Idaae45a304c746c163b214e2d08e00870c69e9d6
    Reviewed-on: https://code.wireshark.org/review/33952
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1b39837   F1AP: upgrade dissector to v15.6.0
     add  1a91aac   Use proto_tree_add_item_ret_string() to add strings.


Summary of changes:
 epan/dissectors/packet-dcm.c | 40 ++++++++++++++++++++++++++++------------
 1 file changed, 28 insertions(+), 12 deletions(-)