Wireshark-commits: [Wireshark-commits] master d22db56: RRC: Remove duplicate dissection of algorith
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 13 Jul 2019 13:43:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d22db568a0517edf7746fd6d7e964d2261e175c6
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d22db56 by Darien Spencer (cusneud@xxxxxxxx):

    RRC: Remove duplicate dissection of algorithm cap bitmaps
    
    This commit is effectively reverting  I88ddc2aec6805a77fcb3f3d547efda4d513ec919
    The dissection logic is now generated into the dissector
    following the changes I2f4258e2f4fd11c26bdc101e1375d0b5708610b7
    and Iec2cb22e61e235a749c7d0f976bae8ad52e6c08f
    
    Change-Id: I871c2b00d7a72103da83d6e64091886a8e2b12ed
    Reviewed-on: https://code.wireshark.org/review/33923
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  41e08a5   s7comm: Implement packet reassembly
     add  d22db56   RRC: Remove duplicate dissection of algorithm cap bitmaps


Summary of changes:
 epan/dissectors/asn1/rrc/packet-rrc-template.c |   4 -
 epan/dissectors/asn1/rrc/rrc.cnf               |  79 ----------
 epan/dissectors/packet-rrc.c                   | 196 +++++++------------------
 3 files changed, 55 insertions(+), 224 deletions(-)