Wireshark-commits: [Wireshark-commits] master 1509d92: Always use string routines to extract string
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 11 Jul 2019 19:28:31 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1509d92f65f1c029480559a24f8b582c4540a1ee
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1509d92 by Guy Harris (guy@xxxxxxxxxxxx):

    Always use string routines to extract strings from packets.
    
    *All* strings have a character encoding, so *all* calls to process
    strings should use routines that take encodings as arguments.  In the
    case of ADB CS services, the encoding is ASCII, so ENC_ASCII.
    
    Change-Id: I1f0e72e1d6c86917d092358487c1df40cf4dec47
    Reviewed-on: https://code.wireshark.org/review/33902
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  bd4e293   wiretap: candump: Reset error info and fix scanner warnings
     add  1509d92   Always use string routines to extract strings from packets.


Summary of changes:
 epan/dissectors/packet-adb_cs.c | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)