Wireshark-commits: [Wireshark-commits] master 3697dd4: idl2wrs: clean up and add python3 compatibil
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3697dd4f5f15a14bc3a4ec477a5c971e9e814556
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
3697dd4 by Yannik Enss (Yannik.Enss@xxxxxxxxxxxxxxxxx):
idl2wrs: clean up and add python3 compatibility
Clean up the python scripts using PEP-8 as a guide, with exceptions
made where necessary.
Includes:
- Move comments to docstrings
- Remove unnecessary whitespace
- Remove brackets from if statements where this improves readability
- Change the debug print statements to output comments
- Remove semicolons
- Prefix debug output with '//'
- Break long lines
Python 3 compatibility changes are mostly converting print statements
and moving away from the string module in favor of `str` methods.
By including the "future" import, compatibility with python 2 is
maintained.
The changes were tested using both omniORB 4.2.2/Python 3.6 and
omniORB 4.1.7/Python 2.7
Change-Id: I8126a49b2fde13982d34e462fced16b9d7b88306
Reviewed-on: https://code.wireshark.org/review/33850
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from b28ae2d macOS: Fix our token wait. Again.
add 3697dd4 idl2wrs: clean up and add python3 compatibility
Summary of changes:
tools/wireshark_be.py | 223 +++---
tools/wireshark_gen.py | 1802 ++++++++++++++++++------------------------------
2 files changed, 775 insertions(+), 1250 deletions(-)