Wireshark-commits: [Wireshark-commits] master 62ca0a6: Qt: Remove glib and wmem from packetlistreco
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 04 Jul 2019 16:34:15 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=62ca0a609bf7a705c09730c5613abf1931c880f5
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

62ca0a6 by Roland Knall (rknall@xxxxxxxxx):

    Qt: Remove glib and wmem from packetlistrecord
    
    These seem to be the last remains of the old gtk interface and can interfere
    with Qt's thread mechanism. Additionally it saves on memory, by only using
    memory needed and a list where more are required
    
    Change-Id: If5945d926d808f3e6f3e74ffc26d392effc3c142
    Reviewed-on: https://code.wireshark.org/review/33845
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  eb46659   Qt: Move ColText to QStringList for PacketListRecord
     add  62ca0a6   Qt: Remove glib and wmem from packetlistrecord


Summary of changes:
 ui/qt/models/packet_list_model.cpp       | 10 +++-------
 ui/qt/models/packet_list_record.cpp      | 33 ++++++++++++++------------------
 ui/qt/models/packet_list_record.h        | 14 ++++----------
 ui/qt/models/related_packet_delegate.cpp |  2 +-
 4 files changed, 22 insertions(+), 37 deletions(-)