Wireshark-commits: [Wireshark-commits] master 66e92e7: Qt: Do not export the model of the packetlis
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 04 Jul 2019 03:56:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=66e92e7276e3d195917faa36fc9833d1fbe10693
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

66e92e7 by Roland Knall (rknall@xxxxxxxxx):

    Qt: Do not export the model of the packetlist
    
    Exporting the model for the packetlist via a function prohibits implementing
    further models (sorting) inside the packetlist
    
    Change-Id: Ica159fc8f242ae1a5b657507a26e33827c366bee
    Reviewed-on: https://code.wireshark.org/review/33834
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8b11de8   MPLS: link CFM to designated G-ACh channel type
     add  66e92e7   Qt: Do not export the model of the packetlist


Summary of changes:
 ui/qt/main_window.cpp               | 12 -----------
 ui/qt/main_window_slots.cpp         |  8 ++++----
 ui/qt/models/packet_list_model.cpp  | 34 +++++++++++++++++++++++++++++-
 ui/qt/packet_list.cpp               | 41 ++++++++++++++++++++++++++-----------
 ui/qt/packet_list.h                 |  4 +++-
 ui/qt/widgets/wireless_timeline.cpp | 11 +++++++---
 6 files changed, 77 insertions(+), 33 deletions(-)