Wireshark-commits: [Wireshark-commits] master 1af6e1f: tap: add credentials tap.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 26 Jun 2019 07:10:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1af6e1f8603825d9781815c6cd25e7dca31ca147
Submitter: "Dario Lombardo <lomato@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1af6e1f by Dario Lombardo (lomato@xxxxxxxxx):

    tap: add credentials tap.
    
    This new tap collects credentials (username and paassword)
    from the dissectors.
    
    So far, few dissectors have been instrumented:
    - http (basic auth)
    - http (header auth)
    - ftp
    Others can be instrumented as well using the same technique.
    
    Tshark has a new option (-z credentials) and Wireshark a new
    "tools" menu: the documentation has been updated accordingly.
    
    Change-Id: I2d0d96598c85bb3ea4fb5ec090dd8dc28b481fc9
    Reviewed-on: https://code.wireshark.org/review/33453
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    

Actions performed:

    from  94d0e08   mmdbresolve: check the return value of malloc
     add  1af6e1f   tap: add credentials tap.


Summary of changes:
 CMakeLists.txt                                     |   1 +
 doc/tshark.pod                                     |   7 +
 docbook/release-notes.adoc                         |   3 +
 docbook/wsug_src/WSUG_chapter_use.adoc             |   1 +
 epan/dissectors/packet-ftp.c                       |  26 ++++
 epan/dissectors/packet-http.c                      |  40 +++++-
 ui/cli/tap-credentials.c                           |  92 ++++++++++++
 ui/qt/CMakeLists.txt                               |   5 +
 ui/qt/credentials_dialog.cpp                       | 104 ++++++++++++++
 ui/qt/credentials_dialog.h                         |  55 ++++++++
 ...tp3_summary_dialog.ui => credentials_dialog.ui} |  36 ++---
 ui/qt/main_window.h                                |   1 +
 ui/qt/main_window.ui                               |   6 +
 ui/qt/main_window_slots.cpp                        |   6 +
 ui/qt/models/credentials_model.cpp                 | 155 +++++++++++++++++++++
 ui/qt/models/credentials_model.h                   |  57 ++++++++
 ui/qt/models/url_link_delegate.h                   |   2 +-
 ui/qt/packet_list.cpp                              |  14 +-
 ui/qt/packet_list.h                                |   3 +-
 ui/tap-credentials.h                               |  26 ++++
 20 files changed, 599 insertions(+), 41 deletions(-)
 create mode 100644 ui/cli/tap-credentials.c
 create mode 100644 ui/qt/credentials_dialog.cpp
 create mode 100644 ui/qt/credentials_dialog.h
 copy ui/qt/{mtp3_summary_dialog.ui => credentials_dialog.ui} (57%)
 create mode 100644 ui/qt/models/credentials_model.cpp
 create mode 100644 ui/qt/models/credentials_model.h
 create mode 100644 ui/tap-credentials.h