Wireshark · Wireshark-commits: [Wireshark-commits] master 5d515bd: make-version: remove defunct --git-description option

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5d515bd0f39c1f8e241a8715fc13979b32e768b8
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5d515bd by Peter Wu (peter@xxxxxxxxxxxxx):

    make-version: remove defunct --git-description option
    
    This option always writes "1" when supplied because of a missing "=s" in
    the argument specification. Aside from that, the regex would produce the
    wrong output for tagged releases. Finally, this command line approach
    would never have worked since version.h is always overwritten by CMake.
    
    Change-Id: I83a4bc3c48a41d566bf70991d2ab181b85071488
    Reviewed-on: https://code.wireshark.org/review/33711
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e66ded5   packet: make sure handle and dissector table exist
     add  5d515bd   make-version: remove defunct --git-description option


Summary of changes:
 tools/make-version.pl | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)