Wireshark-commits: [Wireshark-commits] master 7dfcb44: asn2wrs: use system lex and yacc from ply if
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 23 Jun 2019 17:31:21 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7dfcb4425adf29590f3daf507d667b330a97b669
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7dfcb44 by Peter Wu (peter@xxxxxxxxxxxxx):

    asn2wrs: use system lex and yacc from ply if available
    
    Tested with python-ply 3.11 and Python 3.7.3 on Arch Linux using the
    'ninja asn1' command.
    
    Bundling lex.py and yacc.py is one distribution method suggested by PLY
    upstream (https://www.dabeaz.com/ply/README.txt), but since it is also
    available in many Linux distributions, we could potentially remove it in
    the future. Windows developers can install it through pip if needed.
    
    Change-Id: I9c847072916ee33da49994820b435ec1d7110303
    Reviewed-on: https://code.wireshark.org/review/33708
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  99a87a6   [Automatic update for 2019-06-23]
     add  7dfcb44   asn2wrs: use system lex and yacc from ply if available


Summary of changes:
 debian/patches/04_asn2wrs_ply.patch | 18 ------------------
 debian/patches/series               |  1 -
 tools/asn2wrs.py                    | 10 ++++++++--
 3 files changed, 8 insertions(+), 21 deletions(-)
 delete mode 100644 debian/patches/04_asn2wrs_ply.patch