Wireshark · Wireshark-commits: [Wireshark-commits] master a9ed943: Qt: Split the filter dropdown arrow icon into dark and light ver

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a9ed94356d1b0cb149351e063014d3bdb94c0cd7
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

a9ed943 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Split the filter dropdown arrow icon into dark and light versions.
    
    The capture and display filter widgets set their dropdown arrow icons
    using CSS, which means we can't use a template icon without a
    significant amount of hackery. This is the only instance where we set an
    icon using CSS, so split it into dark and light versions and use them as
    appropriate.
    
    Ping-Bug: 15511
    Change-Id: I699ddc327d8eb109129e60bcb5036b14e6e34414
    Reviewed-on: https://code.wireshark.org/review/33696
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  70d6195   QUIC: add 0-RTT decryption support (draft -20)
     add  a9ed943   Qt: Split the filter dropdown arrow icon into dark and light versions.


Summary of changes:
 image/stock_icons.qrc                              |   6 +-
 image/stock_icons/14x14/x-filter-dropdown.dark.png | Bin 0 -> 224 bytes
 ...ter-dropdown.svg => x-filter-dropdown.dark.svg} |  17 ++---
 .../14x14/x-filter-dropdown.dark@xxxxxx            | Bin 0 -> 268 bytes
 ...er-dropdown.png => x-filter-dropdown.light.png} | Bin
 ...er-dropdown.svg => x-filter-dropdown.light.svg} |   0
 ...pdown@xxxxxx => x-filter-dropdown.light@xxxxxx} | Bin
 image/stock_icons/svg-to-png.sh                    |   3 +-
 ui/qt/widgets/capture_filter_combo.cpp             |  79 +++++++++++++--------
 ui/qt/widgets/capture_filter_combo.h               |   4 +-
 ui/qt/widgets/display_filter_combo.cpp             |  72 +++++++++++--------
 ui/qt/widgets/display_filter_combo.h               |   5 +-
 12 files changed, 113 insertions(+), 73 deletions(-)
 create mode 100644 image/stock_icons/14x14/x-filter-dropdown.dark.png
 copy image/stock_icons/14x14/{x-filter-dropdown.svg => x-filter-dropdown.dark.svg} (90%)
 create mode 100644 image/stock_icons/14x14/x-filter-dropdown.dark@xxxxxx
 rename image/stock_icons/14x14/{x-filter-dropdown.png => x-filter-dropdown.light.png} (100%)
 rename image/stock_icons/14x14/{x-filter-dropdown.svg => x-filter-dropdown.light.svg} (100%)
 rename image/stock_icons/14x14/{x-filter-dropdown@xxxxxx => x-filter-dropdown.light@xxxxxx} (100%)