Wireshark · Wireshark-commits: [Wireshark-commits] master 2d96da9: BSSMAP: Use correct IE number for Selected PLMN ID

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d96da9b7f00b6c3a3339784b7716c54a831cdf3
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

2d96da9 by Pau Espin Pedrol (pespin@xxxxxxxxxxx):

    BSSMAP: Use correct IE number for Selected PLMN ID
    
    Since IE number used to match during parsing is implied from enum
    position, having those enum values commented out make
    BE_SELECTED_PLMN_ID fall in the wrong position (expected 0x94), and thus
    not matching it correctly during parse.
    
    Enabling the not-yet fully supported IEs which were under "ifdef 0"
    doesn't make the current situation worse than before, so let's simply
    enable it and pass NULL as a function for those.
    
    Change-Id: I70063e653acf588f3d07bb8900afa3a48e124d6d
    Reviewed-on: https://code.wireshark.org/review/33667
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  830bd41   DIAMETER: Add MIP6-Feature-Vector flag decode
     add  2d96da9   BSSMAP: Use correct IE number for Selected PLMN ID


Summary of changes:
 epan/dissectors/packet-gsm_a_bssmap.c | 14 +++++---------
 epan/dissectors/packet-gsm_a_common.h |  2 --
 2 files changed, 5 insertions(+), 11 deletions(-)