Wireshark-commits: [Wireshark-commits] master 3f18d7a: TCP: add expert items to MSS option
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 17 Jun 2019 14:10:50 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3f18d7a4cad4856ff6c6418cd866b5b56ea3b282
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3f18d7a by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    TCP: add expert items to MSS option
    
    The TCP MSS option is annotated by expert items as follows:
    - in a SYN packet the lack of the MSS option could indicate
    a misconfigured node.
    - in a non-SYN packet the presence of the MSS option could indicate
    a malfunctioning node.
    
    Change-Id: Ie3827cd6c7dcf605ac2f72a3a080418611637070
    Reviewed-on: https://code.wireshark.org/review/33632
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9515d49   OSPF: Add Node/Link MSD TLVs (rfc8476)
     add  3f18d7a   TCP: add expert items to MSS option


Summary of changes:
 epan/dissectors/packet-tcp.c | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)