Wireshark · Wireshark-commits: [Wireshark-commits] master 142e024: Get rid of the nt_trans_data structure.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=142e024e1f020dae8743276b00eb407447285eb7
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

142e024 by Guy Harris (guy@xxxxxxxxxxxx):

    Get rid of the nt_trans_data structure.
    
    It was used for two purposes:
    
    	1) passing the subcommand to dissectors for the request setup,
    	   parameters, and data;
    
    	2) getting the security descriptor and extended attribute length
    	   from the request parameters and passing them to the dissector
    	   for the request data.
    
    It was completely unused for responses.
    
    Pass the subcommand as an argument to all routines that need it,
    pass pointers to local variables to the request parameters dissector,
    and pass those variables to the request data dissector.
    
    This makes it a bit clearer what information is needed where, and
    completely eliminates the structure for response dissection.
    
    Change-Id: I431daa79da41dc4166490a564efee71cdb83edc1
    Reviewed-on: https://code.wireshark.org/review/33614
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a691985   Convert the zoom icons to templates.
     add  142e024   Get rid of the nt_trans_data structure.


Summary of changes:
 epan/dissectors/packet-smb.c | 80 ++++++++++++++++++++------------------------
 1 file changed, 36 insertions(+), 44 deletions(-)