Wireshark · Wireshark-commits: [Wireshark-commits] master 1379591: wslua: clean up DissectorTable_new()

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=13795914a13fc559800aa123f29171b8d700e22d
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1379591 by Martin Kaiser (wireshark@xxxxxxxxx):

    wslua: clean up DissectorTable_new()
    
    Reorder the code to have a single return statement at the end.
    Take advantage of the fact that WSLUA_OPTARG_ERROR terminates
    the C function that called it.
    
    Do only the parameter checks in the switch-case statement.
    
    Get rid of the intermediate steps when we copy name and ui_name.
    
    Change-Id: Ie8917d19589a6ee16a4a5d14f2c1711d35cc8114
    Reviewed-on: https://code.wireshark.org/review/33607
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  fea4856   Qt: Use UTF8_HORIZONTAL_ELLIPSIS
     add  1379591   wslua: clean up DissectorTable_new()


Summary of changes:
 epan/wslua/wslua_dissector.c | 59 ++++++++++++++++++++++++--------------------
 1 file changed, 32 insertions(+), 27 deletions(-)