Wireshark-commits: [Wireshark-commits] master 33bc4fe: USB: Do not assume that request is standard
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 14 Jun 2019 20:22:17 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=33bc4fede9b99677e4f09b8aed89bc14d33a5da5
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

33bc4fe by Tomasz Moń (desowin@xxxxxxxxx):

    USB: Do not assume that request is standard
    
    USBPcap control status packets for non standard request types (eg.
    Vendor) were incorrectly treated as the standard request type. This
    resulted in confusing Info column description.
    
    Describe status packet of non standard request types as "URB_CONTROL
    status". Do not try any extra labelling as the overall idea of
    Setup/Data/Status is not too good and will be revised in future USBPcap
    versions.
    
    Ping-Bug: 11743
    Ping-Bug: 15842
    Change-Id: Iade5cb85aa01e65874006eb4c7a242568f07b7c8
    Reviewed-on: https://code.wireshark.org/review/33596
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  74d4fcd   DOCSIS: Fixed Info Field Bonded Initial Ranging Request
     add  33bc4fe   USB: Do not assume that request is standard


Summary of changes:
 epan/dissectors/packet-usb.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)