Wireshark-commits: [Wireshark-commits] master 292193b: batadv: Fix info column seqno of IV_OGM v15
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 11 Jun 2019 17:44:32 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=292193bff197190597872025f3d333860a9abc04
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

292193b by Sven Eckelmann (sven@xxxxxxxxxxxxx):

    batadv: Fix info column seqno of IV_OGM v15 packets
    
    The sequence number shown in the info field is read from the
    iv_ogm_packet_v15 object before the actual member is actual read from the
    packet buffer. Just split the initialization of the info column to the
    actual dissection code for the packet to avoid these kind of problems.
    
    Change-Id: I8eb637aae17680d227116156ef7828e77e36beae
    Fixes: 4cc431579363 ("batadv: Add dissector support for batadv v15")
    Signed-off-by: Sven Eckelmann <sven@xxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/33547
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  c600e15   DOCSIS: Adding missing MDD TLVs
     add  292193b   batadv: Fix info column seqno of IV_OGM v15 packets


Summary of changes:
 epan/dissectors/packet-batadv.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)