Wireshark · Wireshark-commits: [Wireshark-commits] master 367bb98: cisco-fp-mim: Adding FabricPath FCS dissection and verification

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=367bb983eecef327f4b73febf0d03015b423a589
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

367bb98 by Alexander Koeppe (format_c@xxxxxxxxx):

    cisco-fp-mim: Adding FabricPath FCS dissection and verification
    
    FabricPath recalculates the FCS based on the whole packet (incl. the Ethernet
    header) and overwrites the last four bytes of the packet, effectively stealing
    the Ethernet FCS.
    
    Since FabricPath FCS dissection and verification isn't available and falsely
    attempted on the Ethernet layer, this commit implements the FCS treatment on
    the FabricPath layer and treats the Ethernet layer explicitely as it would not
    have a FCS.
    
    It also adds a procotol option to enable FabricPath FCS validation which is
    disabled by default though.
    
    Bug: 15769
    Change-Id: I382a4907bca158b549bcc8d77459b7829e60f94a
    Reviewed-on: https://code.wireshark.org/review/33322
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e0d0130   FTDI FT: Initial USB Bridging Devices dissector
     add  367bb98   cisco-fp-mim: Adding FabricPath FCS dissection and verification


Summary of changes:
 epan/dissectors/packet-cisco-fp-mim.c | 63 +++++++++++++++++++++++++++++------
 1 file changed, 53 insertions(+), 10 deletions(-)