Wireshark-commits: [Wireshark-commits] master 5e79558: TLS: fix crash on handshake reassembly with
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 09 Jun 2019 23:38:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5e79558a8243c046ce3f279c635f9670be7f8f05
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5e79558 by Peter Wu (peter@xxxxxxxxxxxxx):

    TLS: fix crash on handshake reassembly with truncated captures
    
    Do not attempt reassembly when it will end up failing due to missing
    data in a tvb. The dissection results will be wrong as the middle of a
    fragment is now interpreted as a full handshake message, but at least
    future handshake records should be correctly interpreted and the null
    pointer crash due to an incomplete reassembly is fixed.
    
    Bug: 15811
    Change-Id: I308d5fa6c131972625f1987d01a8c207e65b4ed2
    Fixes: v3.1.0rc0-620-gb641febb1e ("TLS: Implement reassembly for Handshake messages")
    Reviewed-on: https://code.wireshark.org/review/33535
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  004d26d   TPKT: Add the dissector to the list of TLS subdissectors
     add  5e79558   TLS: fix crash on handshake reassembly with truncated captures


Summary of changes:
 epan/dissectors/packet-tls.c | 30 ++++++++++++++++++++++--------
 1 file changed, 22 insertions(+), 8 deletions(-)