Wireshark-commits: [Wireshark-commits] master 13fc830: QUIC: fix decryption after Version Negotiati
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 09 Jun 2019 23:18:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=13fc8302e09d1b9885d4d853aeb40b27c549b33c
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

13fc830 by Peter Wu (peter@xxxxxxxxxxxxx):

    QUIC: fix decryption after Version Negotiation
    
    After a Version Negotiation, the handshake starts over with a new Client
    Initial that have different DCID and SCID. Be sure not to link these
    subsequent packets to the first session as that would break decryption.
    
    Tested with a QUANT capture provided by Lars Eggert. Regression tested
    against ngtcp2-19-dsb.pcapng, decryption still works there.
    
    Bug: 13881
    Change-Id: Ia6253c1f2ff39fbe5ce130966129215be479a20a
    Reviewed-on: https://code.wireshark.org/review/33525
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  6476ec7   Document why extcap utilities can't be run "by hand" on Windows
     add  13fc830   QUIC: fix decryption after Version Negotiation


Summary of changes:
 epan/dissectors/packet-quic.c | 22 +++++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)