Wireshark-commits: [Wireshark-commits] master-2.4 4fe658b: Fix the dissection of Find First2 Query
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 04 Jun 2019 22:18:16 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4fe658b27f2b7246120475640841c61159dbe0b0
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

4fe658b by Guy Harris (guy@xxxxxxxxxxxx):

    Fix the dissection of Find First2 Query EA Info information.
    
    The file name doesn't appear to be padded, and may have a 1-byte null
    terminator (yes, 1 byte, according to MS-CIFS) at the end, not included
    in the file name length.
    
    Change-Id: I8510434b3b5aec092290697c336924d6ff6be763
    Reviewed-on: https://code.wireshark.org/review/33486
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 782c4e496bc6d3610f504b06690e7848abd4453a)
    Reviewed-on: https://code.wireshark.org/review/33492
    

Actions performed:

    from  8645833   Handle some weirdness with the primary domain field in NegProt replies.
     add  4fe658b   Fix the dissection of Find First2 Query EA Info information.


Summary of changes:
 epan/dissectors/packet-smb.c | 23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)