Wireshark-commits: [Wireshark-commits] master-2.4 8645833: Handle some weirdness with the primary d
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 04 Jun 2019 22:16:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=864583349ecdfe3bd794aefb14df4009a5ddde4c
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

8645833 by Guy Harris (guy@xxxxxxxxxxxx):

    Handle some weirdness with the primary domain field in NegProt replies.
    
    Sometimes there appears to be an extra byte before that field; try to
    catch some of those cases.
    
    Expand comments discussing various weirdness with that field, including
    a note that clients might not pay any attention to it, so maybe we just
    have buggy servers talking to clients that don't care about those
    particular bugs.
    
    Change-Id: I4d35d2e2c475d4da37debedfed31b891e6f3cfa8
    Reviewed-on: https://code.wireshark.org/review/33481
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 021e994293449ac263b0b234660847e27363a660)
    Reviewed-on: https://code.wireshark.org/review/33489
    

Actions performed:

    from  3c99be0   Fix the dissection of create temporary file responses.
     add  8645833   Handle some weirdness with the primary domain field in NegProt replies.


Summary of changes:
 epan/dissectors/packet-smb.c | 66 ++++++++++++++++++++++++++++++++++++++------
 1 file changed, 58 insertions(+), 8 deletions(-)