Wireshark-commits: [Wireshark-commits] master-2.6 49d510f: Fix the dissection of create temporary f
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 04 Jun 2019 21:48:51 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=49d510ff3a1c4abfde8c0a81f05a5b67d3b10906
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

49d510f by Guy Harris (guy@xxxxxxxxxxxx):

    Fix the dissection of create temporary file responses.
    
    According to MS-CIFS:
    
    	1) the file name is not one of those "buffer format followed by
    	   a string" fields, it's just a string, so there's no buffer
    	   format field;
    
    	2) it's always in ASCII, so ignore the "Unicode strings" flag.
    
    Note that, for the *request*, the *directory* name isn't claimed to
    always be ASCII, so honor the "Unicode strings" flag there.
    
    Change-Id: I495b7be8257d941ccf4b45126a44d25cf0ab2c12
    Reviewed-on: https://code.wireshark.org/review/33482
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 6259b79d257fac11cda823b7bf0e4f291d68186b)
    Reviewed-on: https://code.wireshark.org/review/33484
    

Actions performed:

    from  03b8132   Add some comments indicating what protocol was selected.
     add  49d510f   Fix the dissection of create temporary file responses.


Summary of changes:
 epan/dissectors/packet-smb.c | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)