Wireshark-commits: [Wireshark-commits] master-2.4 3c38cf2: Add some comments indicating what protoc
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 04 Jun 2019 20:04:21 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3c38cf2c67a36349ab4e42f29bf27d855c031751
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

3c38cf2 by Guy Harris (guy@xxxxxxxxxxxx):

    Add some comments indicating what protocol was selected.
    
    Note, for all of the different word count values, what protocol or
    protocols it represents.
    
    (If we have the Negotiate request, and can thus determine which protocol
    was selected based on the set of protocols the client was willing to
    accept, should we verify that the server selected a protocol for which
    the given word count value was used, and add an expert info if it
    didn't?)
    
    Change-Id: I95ad4b1245bf2a04fdef4746815352967d8ac0a6
    Reviewed-on: https://code.wireshark.org/review/33475
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit cdaa04cc30669cb0a9272b692cf5a152ef6612c4)
    Reviewed-on: https://code.wireshark.org/review/33478
    

Actions performed:

    from  c32f150   Register the "missing word parameters" expert info.
     add  3c38cf2   Add some comments indicating what protocol was selected.


Summary of changes:
 epan/dissectors/packet-smb.c | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)