Wireshark-commits: [Wireshark-commits] master-3.0 a38621a: Add some comments indicating what protoc
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 04 Jun 2019 20:03:53 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a38621a708133a6561101920418da32e1284d6b4
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

a38621a by Guy Harris (guy@xxxxxxxxxxxx):

    Add some comments indicating what protocol was selected.
    
    Note, for all of the different word count values, what protocol or
    protocols it represents.
    
    (If we have the Negotiate request, and can thus determine which protocol
    was selected based on the set of protocols the client was willing to
    accept, should we verify that the server selected a protocol for which
    the given word count value was used, and add an expert info if it
    didn't?)
    
    Change-Id: I95ad4b1245bf2a04fdef4746815352967d8ac0a6
    Reviewed-on: https://code.wireshark.org/review/33475
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 8ba992d42f654a6ee4cc5e75175b6170d2dc8d18)
    Reviewed-on: https://code.wireshark.org/review/33476
    

Actions performed:

    from  c476bc3   Register the "missing word parameters" expert info.
     add  a38621a   Add some comments indicating what protocol was selected.


Summary of changes:
 epan/dissectors/packet-smb.c | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)