Wireshark-commits: [Wireshark-commits] master-2.6 8abffd9: Don't assume an NT Create AndX request h
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 04 Jun 2019 19:49:08 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8abffd99292c0dc13bec37469393d4a1e1772ced
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

8abffd9 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't assume an NT Create AndX request has all the word parameters.
    
    It *should*, but a malicious or otherwise malformed packet might not
    have them.  One of them is the file name length; if it's missing, we
    can't dissect the file name, as we don't know how long it is.
    
    Change-Id: Ie259e2d8ec65f5d53d466382d89889902495d2c8
    Reviewed-on: https://code.wireshark.org/review/33467
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit f0c13af7d3862f11b47cfcb12ccc80341122395d)
    Reviewed-on: https://code.wireshark.org/review/33471
    

Actions performed:

    from  c839f9e   rpm-setup.sh: We no longer use FOP or AsciiDoc.
     add  8abffd9   Don't assume an NT Create AndX request has all the word parameters.


Summary of changes:
 epan/dissectors/packet-smb.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)