Wireshark-commits: [Wireshark-commits] master-3.0 ce41aa1: Fix for incorrectly decoded RSL ERR REP/
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 28 May 2019 03:29:47 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ce41aa13d7aacd7d0b20f72c443a03224d767683
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

ce41aa1 by Eric Wild (ewild@xxxxxxxxxxx):

    Fix for incorrectly decoded RSL ERR REP/BCCH INFORMATION optional IEs
    
    This patch adjusts the inconsistent usage of the is_mandatory flag
    passed to the dissect_* functions for optional IEs, which fixes the
    issue of incorrectly parsed RSL ERR REP optional IEs and the equally
    broken BCCH INFORMATION optional IE parsing.
    
    Bug: 15789
    Change-Id: I94ea8fe110d8d6aa6ebd0cec5013d3cc8fd55311
    Reviewed-on: https://code.wireshark.org/review/33269
    Reviewed-by: Harald Welte <laforge@xxxxxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit bc9f570680862c7835eb58488230b40a9e89251e)
    Reviewed-on: https://code.wireshark.org/review/33388
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    

Actions performed:

    from  52ecb59   Clean up some ASCII vs. EBCDIC string handling.
     add  ce41aa1   Fix for incorrectly decoded RSL ERR REP/BCCH INFORMATION optional IEs


Summary of changes:
 epan/dissectors/packet-rsl.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)