Wireshark-commits: [Wireshark-commits] master-3.0 94bfb23: *Always* pair ENC_UTF_16 and ENC_UCS_2 w
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 26 May 2019 18:44:10 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=94bfb2364d467f973115ee3608974d2eaacd8d6d
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

94bfb23 by Guy Harris (guy@xxxxxxxxxxxx):

    *Always* pair ENC_UTF_16 and ENC_UCS_2 with a byte order.
    
    Big-endian and little-endian UTF-16 and UCS-2 aren't the same; always
    associate them with a byte order ENC_ flag, to clarify what byte order
    is being used.  Yes, for big-endian, omitting the ENC_ flag, or using
    ENC_NA, *happens* to work, because ENC_BIG_ENDIAN and ENC_NA *happen* to
    be 0, but omitting ENC_BIG_ENDIAN doesn't make it sufficiently clear
    that it's UTF-16BE or UCS-2BE.
    
    Change-Id: Iecf7375763ce4922bd1b0676c9dc5a01731c2fec
    Reviewed-on: https://code.wireshark.org/review/33374
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 2c63e5ef5e6111de64fc4a3c3059fac995567e2a)
    Reviewed-on: https://code.wireshark.org/review/33375
    

Actions performed:

    from  245a9b3   [Automatic update for 2019-05-26]
     add  94bfb23   *Always* pair ENC_UTF_16 and ENC_UCS_2 with a byte order.


Summary of changes:
 epan/dissectors/packet-hiqnet.c    | 12 ++++++------
 epan/dissectors/packet-isobus-vt.c |  6 +++---
 2 files changed, 9 insertions(+), 9 deletions(-)