Wireshark-commits: [Wireshark-commits] master-3.0 e2909bf: Qt: unchecked dynamic cast
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 25 May 2019 06:47:20 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e2909bf80f443898aadbb9ab76f708b6c8d9b6ca
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

e2909bf by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Qt: unchecked dynamic cast
    
    Dynamic cast may yield NULL pointer, hence must be checked before
    dereferencing it. Easy enough in a conditional.
    
    CID 1435488
    
    Change-Id: I8359ab5865795f1b1bea6980b023ff636d6719a6
    Reviewed-on: https://code.wireshark.org/review/33316
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 29283decd7f312e54560cf53398a0809aac37803)
    Reviewed-on: https://code.wireshark.org/review/33340
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  bfb2dd2   *Little-endian* UTF-16.
     add  e2909bf   Qt: unchecked dynamic cast


Summary of changes:
 ui/qt/wlan_statistics_dialog.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)