Wireshark-commits: [Wireshark-commits] master c5b2808: QUIC: Fix broken Key Update support
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 20 May 2019 16:53:56 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c5b2808623c62d8f4a61562c648072b47cfbc424
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c5b2808 by Peter Wu (peter@xxxxxxxxxxxxx):

    QUIC: Fix broken Key Update support
    
    Use the standard TLS 1.3 Key Update variant (broken since draft -13).
    Fix key_phase change detection (gboolean is signed, and 1 != -1, so it
    would always trigger a key update when KP1).
    Fix typo that breaks Key Update for the client (server_pp -> pp_state).
    
    Tested with attachment 17132 from the linked bug.
    
    Bug: 13881
    Change-Id: I0246816e99d2e3ed509aa3ebb8a57b753399dde4
    Reviewed-on: https://code.wireshark.org/review/33279
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  de5fd16   isobus-vt: fix typo
     add  c5b2808   QUIC: Fix broken Key Update support


Summary of changes:
 epan/dissectors/packet-quic.c | 63 +++++++++----------------------------------
 1 file changed, 13 insertions(+), 50 deletions(-)