Wireshark · Wireshark-commits: [Wireshark-commits] master-3.0 f5938fe: Qt: Fix no interface load preference handling

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f5938fe89148130e9eea153c19adbb97a42eb8bf
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

f5938fe by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Qt: Fix no interface load preference handling
    
    In handling the capture preferences frame, the preference to not load
    interfaces on startup is handled incorrectly. Instead of using the
    preference value itself, the validity of the pointer to the preference is
    used. This leads to some confusing logic.
    Replacing this code with proper preference retrieval.
    This was introduced with commit 7a07832712cc0b533acadec2d627528e624033b6
    
    CID 1439697
    
    Change-Id: I9bf3df413d89f8df55553a7218f34d425eb103de
    Reviewed-on: https://code.wireshark.org/review/33187
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 1bdac82696757e18cc994421167eb9789d2429ae)
    Reviewed-on: https://code.wireshark.org/review/33213
    

Actions performed:

    from  840eba7   Qt: do not expose a UAT record if the update callback fails
     add  f5938fe   Qt: Fix no interface load preference handling


Summary of changes:
 ui/qt/capture_preferences_frame.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)