Wireshark-commits: [Wireshark-commits] master-3.0 cd855bc: Fix SMB2 decryption on big-endian machin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 14 May 2019 01:30:53 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cd855bc16476ad1496bc81d984cd3cea91f98495
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

cd855bc by Guy Harris (guy@xxxxxxxxxxxx):

    Fix SMB2 decryption on big-endian machines.
    
    Convert the host-endian session ID passed to seskey_find_sid_key()
    before comparing it with the little-endian session IDs in the UAT.
    
    While we're at it, tag session ID fields in various structures with the
    byte order.
    
    Bug: 15772
    Change-Id: Ib1e7323bad1dfdb1ac24a08998205650f2744097
    Reviewed-on: https://code.wireshark.org/review/33188
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 0d0f494336b9ad9eabadeba899196081b71fd514)
    Reviewed-on: https://code.wireshark.org/review/33189
    

Actions performed:

    from  26aba09   Fix the length of the item added for the value field of undissected CLVs.
     add  cd855bc   Fix SMB2 decryption on big-endian machines.


Summary of changes:
 epan/dissectors/packet-smb2.c | 21 +++++++++++++++++++--
 epan/dissectors/packet-smb2.h |  8 ++++----
 2 files changed, 23 insertions(+), 6 deletions(-)