Wireshark-commits: [Wireshark-commits] master b06dcb3: nvme-tcp: Add nvme-tcp dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 13 May 2019 06:11:58 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b06dcb32c79d5108990e0efb2118fcecb2312022
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b06dcb3 by Solganik Alexander (solganik@xxxxxxxxx):

    nvme-tcp: Add nvme-tcp dissector
    
    This patch adds support of NVMe/TCP (NVM Express over Fabrics for TCP).
    to wireshark.
    
    NVM Express is high speed interface for accessing solid state drives.
    NVM Express specifications are maintained by NVM Express industry
    association at https://nvmexpress.org/.
    
    NVMe/TCP is the TCP transport binding specification
    which recently ratified (Technical Proposal 8000) and is a part
    of NVMe-oF spec version 1.1.
    
    Reference can be found here:
    https://lwn.net/Articles/772556/
    and protocol specification:
    https://nvmexpress.org/welcome-nvme-tcp-to-the-nvme-of-family-of-transports/
    
    Supported commands are
    *) NVMe/TCP ICREQ, ICRESP.
    *) NVMe Fabrics commands
    *) NVMe commands that are supported by packet-nvme dissector.
    
    Testing is done with Linux 5.0 nvme-tcp host and target drivers.
    H2C and C2H termination PDU`s are not supported as Linux NVMe/TCP driver
    does not support them as well in kernel 5.0
    
    Bug: 15735
    Change-Id: I63ae7aa2a42ff843b9832110830fd345f30d9170
    Reviewed-on: https://code.wireshark.org/review/32640
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  23744c9   tools: add speexdsp to debian-setup.
     add  b06dcb3   nvme-tcp: Add nvme-tcp dissector


Summary of changes:
 docbook/release-notes.adoc        |    1 +
 epan/dissectors/CMakeLists.txt    |    1 +
 epan/dissectors/packet-nvme-tcp.c | 1473 +++++++++++++++++++++++++++++++++++++
 epan/dissectors/packet-nvme.c     |   37 +-
 epan/dissectors/packet-nvme.h     |   19 +
 5 files changed, 1529 insertions(+), 2 deletions(-)
 create mode 100644 epan/dissectors/packet-nvme-tcp.c