Wireshark-commits: [Wireshark-commits] master 9ddb50f: BSSMAP: Further decode the GCR (Global Call
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 10 May 2019 10:44:26 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9ddb50f33f86da361e3d56d92ade08f5cc8a44dd
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9ddb50f by Harald Welte (laforge@xxxxxxxxxxxx):

    BSSMAP: Further decode the GCR (Global Call Reference) field
    
    The BSSMAP LCLS GCR field is specified in 3GPP TS 29.205, which
    in turn was originally created to augment the ITU-T Q.190x BICC
    with Mobile specific information elements.  Let's add the latter
    decoding function as a new packet-bicc_mst.c, so it can be used
    also from other dissectors.  For example, GSM MAP also includes
    GCRs and hence should be modified to use this new decoder.
    
    Change-Id: I247d2ccd2d16e996f4fe5d5952ba8a4091a4ffd0
    Reviewed-on: https://code.wireshark.org/review/33117
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  32fa74c   GSUP: Add dissection of BSSMAP, RR and SM cause values
     add  9ddb50f   BSSMAP: Further decode the GCR (Global Call Reference) field


Summary of changes:
 epan/dissectors/CMakeLists.txt        |   2 +
 epan/dissectors/packet-bicc_mst.c     | 102 ++++++++++++++++++++++++++++++++++
 epan/dissectors/packet-bicc_mst.h     |  26 +++++++++
 epan/dissectors/packet-gsm_a_bssmap.c |  16 +++---
 4 files changed, 137 insertions(+), 9 deletions(-)
 create mode 100644 epan/dissectors/packet-bicc_mst.c
 create mode 100644 epan/dissectors/packet-bicc_mst.h