Wireshark-commits: [Wireshark-commits] master 405439d: QUIC: fix wrong dissection of ODCIL
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 09 May 2019 16:41:12 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=405439d41d479571e985f6248bd2a3b976c25797
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

405439d by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    QUIC: fix wrong dissection of ODCIL
    
    Since draft 17, IETF QUIC retry packets carry the Original Destination Connection ID Length (ODCIL)
    in the four least-significant bits of the first byte.
    However Wireshark's QUIC dissector expects the ODCIL to be after the source connection ID,
    which was the behaviour before draft 17, which results in incorrect dissection
    
    Issue reported by Jeremy Lainé
    
    Bug: 15764
    Change-Id: I7c6ed2988a0b0ab3f4dfe6de9f9571ae522148cf
    Reviewed-on: https://code.wireshark.org/review/33116
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ff7f584   bacapp: fix wrong value for id 183
     add  405439d   QUIC: fix wrong dissection of ODCIL


Summary of changes:
 epan/dissectors/packet-quic.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)