Wireshark-commits: [Wireshark-commits] master-3.0 a22befe: QUIC: fix transport parameter heuristics
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 01 May 2019 21:50:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a22befea18e109e4022bc2332d543232866eb1a7
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

a22befe by Peter Wu (peter@xxxxxxxxxxxxx):

    QUIC: fix transport parameter heuristics for draft -18 and older
    
    "initial_version" might not contain a valid QUIC version if the initial
    packet is used to trigger version negotiation. This was observed with
    quiche (on draft -18) which uses 0xbabababa. Change heuristics to detect
    the new format instead.
    
    Bug: 13881
    Change-Id: I8f1dc466575f37a27ee579a6e3dd38e154c3fa5d
    Reviewed-on: https://code.wireshark.org/review/33032
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit e20b924d3463079440f8ce1a0945b1ee3e3992d9)
    Reviewed-on: https://code.wireshark.org/review/33036
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  e09def2   mqtt: Check for a valid payload protocol
     add  a22befe   QUIC: fix transport parameter heuristics for draft -18 and older


Summary of changes:
 epan/dissectors/packet-tls-utils.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)