Wireshark-commits: [Wireshark-commits] master a748f8f: Clean up the new-file selection criteria in
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a748f8f41a64e1f3990c11fd4648362f41016c03
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
a748f8f by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):
Clean up the new-file selection criteria in the GUI.
Inspired by looking into
https://ask.wireshark.org/question/8009/wireshark-ring-buffer-settings-from-command-line/
... in which the user was confused because a duration set on the command
line was not reflected in the GUI. That's because
I0180c43843f5d2f0c2f50153c9ce42ac7fa5aeae added the `interval` ring-buffer
option and made the GUI use this rather than `duration`. This was not at all
clear in the GUI, though.
Since `duration` and `interval` have quite different use cases, expose both in
the GUI.
Try to clean up and unify the tooltips at the same time. I'm not entirely
convinced the tooltips need to be on the checkbox, the spinbox, and the
combobox but leave it that way for now.
Add some to the man page description of the interval option to hopefully make
it clearer what the option does.
Change-Id: I3b45fe71c33af64d980dffb5e5ba93e2a15a6b96
Reviewed-on: https://code.wireshark.org/review/32526
Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 5a98368 print: don't ignore FT_NONE fields in ek.
add a748f8f Clean up the new-file selection criteria in the GUI.
Summary of changes:
doc/dumpcap.pod | 3 +-
doc/tshark.pod | 3 +-
ui/qt/capture_interfaces_dialog.cpp | 22 +++++++--
ui/qt/capture_interfaces_dialog.ui | 90 ++++++++++++++++++++++++++++++++-----
4 files changed, 101 insertions(+), 17 deletions(-)
