Wireshark-commits: [Wireshark-commits] master-3.0 f80b7d1: gsm_gsup: check the current len against
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 13 Mar 2019 11:32:05 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f80b7d1b279fb6c13f640019a1bbc42b18bf7469
Submitter: "Dario Lombardo <lomato@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

f80b7d1 by Dario Lombardo (lomato@xxxxxxxxx):

    gsm_gsup: check the current len against the caller length.
    
    When the former is greater than the latter, we have a malformed
    packet. Add an expert info and stop the dissection.
    
    Bug: 15585
    Change-Id: I37e35ed7bfe96fe6896fa5bf3c32bae50a427c60
    Reviewed-on: https://code.wireshark.org/review/32382
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Oliver Smith <osmith@xxxxxxxxxxx>
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    (cherry picked from commit 5d9d7893d6723b4545d4c2c765002e4830493dc6)
    Reviewed-on: https://code.wireshark.org/review/32396
    

Actions performed:

    from  46d04be   Add macros for the pack_flags field.
     add  f80b7d1   gsm_gsup: check the current len against the caller length.


Summary of changes:
 epan/dissectors/packet-gsm_gsup.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)