Wireshark-commits: [Wireshark-commits] master-3.0 e7362bd: ieee80211: check offset before using it.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 06 Mar 2019 19:42:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e7362bd429d5c9c7945a0e275045499d4dcb6250
Submitter: "Dario Lombardo <lomato@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

e7362bd by Dario Lombardo (lomato@xxxxxxxxx):

    ieee80211: check offset before using it.
    
    If we go over 31, we get an invalid shift. It's due to malformed
    packets. Add an expert info and exit the loop.
    
    Bug: 14770
    Change-Id: Icc17831ee23395ed2b0d414af09d86d1d1a6444c
    Reviewed-on: https://code.wireshark.org/review/32316
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 8f1751ce400de17ffad0eac3cb01ca4544141e26)
    Reviewed-on: https://code.wireshark.org/review/32341
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    

Actions performed:

    from  fb94bfe   srvloc: check buffer index to prevent heap overflow.
     add  e7362bd   ieee80211: check offset before using it.


Summary of changes:
 epan/dissectors/packet-ieee80211.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)