Wireshark-commits: [Wireshark-commits] master daf29e2: smb2: cleanup sockaddr dissector and make mo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 05 Mar 2019 04:51:04 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=daf29e2bde25f931908f4b17ee5866f90f84b3ce
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

daf29e2 by Aurelien Aptel (aaptel@xxxxxxxx):

    smb2: cleanup sockaddr dissector and make more generic
    
    * make the following return post-dissect offset:
      - dissect_windows_sockaddr_in
      - dissect_windows_sockaddr_in6
      - dissect_windows_sockaddr_storage
    
    * expose 'len' optional argument to dissect padded data
    
    Change-Id: I83f0981b5aeb6a6f1f08df63fd1513d4b1dcbcef
    Reviewed-on: https://code.wireshark.org/review/32313
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  69460d4   maxmind_db: Work around an apparent GLib bug.
     add  daf29e2   smb2: cleanup sockaddr dissector and make more generic


Summary of changes:
 epan/dissectors/packet-smb2.c | 34 ++++++++++++++++------------------
 1 file changed, 16 insertions(+), 18 deletions(-)