Wireshark-commits: [Wireshark-commits] master 7bf2fbf: Replace another tvb_new_subset_length_caplen
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 28 Feb 2019 18:48:34 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7bf2fbf85a083a2530901cfdf2eede1512e8529b
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7bf2fbf by Guy Harris (guy@xxxxxxxxxxxx):

    Replace another tvb_new_subset_length_caplen() call.
    
    tvb_new_subset_length() is sufficient, and correctly calculates the
    captured length of the tvbuff, rather than possibly setting it too large
    by setting it based on the length of the TLV header.
    
    Change-Id: I510ee6742fcbc08ae7331585a65c768e98e6b3d9
    Reviewed-on: https://code.wireshark.org/review/32271
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  bf8ca6a   Replace a tvb_new_subset_length_caplen() call with tvb_new_subset_remaining().
     add  7bf2fbf   Replace another tvb_new_subset_length_caplen() call.


Summary of changes:
 epan/dissectors/packet-ieee802154.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)