Wireshark · Wireshark-commits: [Wireshark-commits] master-3.0 b003c6f: Change maxmind_db_lookup_ipv4 to look more like maxmind_db_l

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b003c6fdd66c0268b3f4d35501c9eea0a6eeb0e9
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

b003c6f by Peter Wu (peter@xxxxxxxxxxxxx):

    Change maxmind_db_lookup_ipv4 to look more like maxmind_db_lookup_ipv6
    
    Both functions accept an address in network byte order, but
    maxmind_db_lookup_ipv4 does not accept a pointer. Add an indirection and
    remove unnecessary memcpy calls. This removes some confusion for me.
    
    Change-Id: I291c54c8c55bc8048ca011b84918c8a5d3ed1398
    Reviewed-on: https://code.wireshark.org/review/31951
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 5c4458345ca686e2f34d9c0d6df257cd82dd14c5)
    Reviewed-on: https://code.wireshark.org/review/31970
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  262d898   maxmind_db: improve debug messages, harden against bad input
     add  b003c6f   Change maxmind_db_lookup_ipv4 to look more like maxmind_db_lookup_ipv6


Summary of changes:
 epan/dissectors/packet-ip.c |  4 ++--
 epan/maxmind_db.c           | 10 +++++-----
 epan/maxmind_db.h           |  5 +++--
 sharkd_session.c            |  5 ++---
 ui/qt/endpoint_dialog.cpp   |  4 +---
 5 files changed, 13 insertions(+), 15 deletions(-)