Wireshark-commits: [Wireshark-commits] master-2.6 d632d88: BER: don't use invalid time offsets.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 28 Jan 2019 15:00:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d632d880251f72791c3ff133378f3ac4280c91f1
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

d632d88 by Dario Lombardo (lomato@xxxxxxxxx):

    BER: don't use invalid time offsets.
    
    4 digits values could overflow the destination buffer. Skip them
    since they're invalid and can only from tainted data.
    
    Bug: 15447
    Change-Id: Ice6d4f144597499483160ecaa63702025ab86f61
    Reviewed-on: https://code.wireshark.org/review/31751
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit cb47fe6b05a70776fdd6df4a84be26f8361587ea)
    Reviewed-on: https://code.wireshark.org/review/31777
    

Actions performed:

    from  753be0b   [Automatic update for 2019-01-27]
     add  d632d88   BER: don't use invalid time offsets.


Summary of changes:
 epan/dissectors/packet-ber.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)