Wireshark-commits: [Wireshark-commits] master 6fbf28f: wslua_nstime: fix memleak for bad arguments
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 26 Jan 2019 09:07:39 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6fbf28f3b8659b835a608e81fc97acfd797042b6
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6fbf28f by Peter Wu (peter@xxxxxxxxxxxxx):

    wslua_nstime: fix memleak for bad arguments to NSTime
    
    luaL_optinteger will raise an error when the argument is an invalid
    number. Delay the allocation to avoid a leak. Fixes the
    test_wslua_nstime test under ASAN.
    
    Change-Id: I6856fd218897565a60786d820f43192b41d489f2
    Reviewed-on: https://code.wireshark.org/review/31744
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ae6b585   ISAKMP: fix memory leaks for IKEv1 decryption
     add  6fbf28f   wslua_nstime: fix memleak for bad arguments to NSTime


Summary of changes:
 epan/wslua/wslua_nstime.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)