Wireshark-commits: [Wireshark-commits] master 728183c: wslua_file_handler: fix leak of opt_comment
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 26 Jan 2019 07:42:07 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=728183c27e778ada5a329a55353b09a83d11ceac
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

728183c by Peter Wu (peter@xxxxxxxxxxxxx):

    wslua_file_handler: fix leak of opt_comment
    
    Since v2.9.1rc0-528-g31aba351e2, it is clear that wtap file formats
    should free earlier comments before writing a new one. Do so.
    Fixes leaks reported by ASAN for test_wslua_file_acme_reader.
    
    Change-Id: Iafb643f01f5973f2d3b88f244ee70e8c0c451080
    Reviewed-on: https://code.wireshark.org/review/31738
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3ee9c0f   GTP: Dissect PDU Session Container.
     add  728183c   wslua_file_handler: fix leak of opt_comment


Summary of changes:
 epan/wslua/wslua_file_handler.c | 3 +++
 epan/wslua/wslua_frame_info.c   | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)