Wireshark-commits: [Wireshark-commits] master 198c5a2: test/dfilter: be explicit with the expected
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 24 Jan 2019 18:24:06 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=198c5a2cac3b954c8c3d8357ae9c1070e1eae594
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

198c5a2 by Peter Wu (peter@xxxxxxxxxxxxx):

    test/dfilter: be explicit with the expected error message
    
    Instead of just reporting a mismatching error code, include the program
    output. This should help tracking down unexpected errors. While at it,
    check the expected error message too.
    
    Change-Id: Ib8fe51cc06b795bb54bfe1e6eaa828c6ba1128ef
    Reviewed-on: https://code.wireshark.org/review/31714
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  a946eb3   ftype-time: parse the month independent of the locale
     add  198c5a2   test/dfilter: be explicit with the expected error message


Summary of changes:
 doc/README.display_filter                    |  8 ++++----
 test/suite_dfilter/dfiltertest.py            | 27 +++++++++++++++++++--------
 test/suite_dfilter/group_dfunction_string.py | 12 ++++++++----
 test/suite_dfilter/group_integer.py          |  9 ++++++---
 test/suite_dfilter/group_string_type.py      |  6 ++++--
 test/suite_dfilter/group_time_type.py        |  9 ++++++---
 6 files changed, 47 insertions(+), 24 deletions(-)